<html>
<head><meta charset="utf-8"><title>Symbol export status · t-compiler/help · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/index.html">t-compiler/help</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Symbol.20export.20status.html">Symbol export status</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="236060541"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Symbol%20export%20status/near/236060541" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cjgillot <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Symbol.20export.20status.html#236060541">(Apr 25 2021 at 12:05)</a>:</h4>
<p><code>src/incremental/change_symbol_export_status.rs</code> verifies we do not reuse a CGU when the visibility attributes cause the symbol export to change. However, this test is buggy: when ignoring spans (with -Zincremental-ignore-spans), the CGU is reused, contrary to the aim of the test.</p>
<p>Where is the code responsible for assigning the visibility to codegen symbols?</p>



<a name="236067238"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Symbol%20export%20status/near/236067238" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Symbol.20export.20status.html#236067238">(Apr 25 2021 at 13:53)</a>:</h4>
<p><span class="user-mention" data-user-id="248906">@cjgillot</span> I think this is it: <a href="https://github.com/rust-lang/rust/blob/06f0adb34570ba83fee391abeb0bec0eec28a234/compiler/rustc_privacy/src/lib.rs#L402">https://github.com/rust-lang/rust/blob/06f0adb34570ba83fee391abeb0bec0eec28a234/compiler/rustc_privacy/src/lib.rs#L402</a></p>



<a name="236067266"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Symbol%20export%20status/near/236067266" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Symbol.20export.20status.html#236067266">(Apr 25 2021 at 13:53)</a>:</h4>
<p>or at least I remember making this change unconditional broke codegen: <a href="https://github.com/rust-lang/rust/blob/06f0adb34570ba83fee391abeb0bec0eec28a234/compiler/rustc_privacy/src/lib.rs#L741-L745">https://github.com/rust-lang/rust/blob/06f0adb34570ba83fee391abeb0bec0eec28a234/compiler/rustc_privacy/src/lib.rs#L741-L745</a>, so codegen is affected by it somehow</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>